Skip to content

Fix issues with outdated package-lock.json file. #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Jul 15, 2022

Our package-lock.json file is outdated and our dependencies are a bit jumbled up.

I didn't notice any issue when using nodejs14 but when using nodejs16 reveals several issues that I've tried to address in the PR:

  1. Update typedoc dependency to avoid impossible dep resolution (first reported Update typedoc from 0.21.2 to ^0.23.7. #1169)

  2. Regenerate package-lock.json. Looks like it's "behind" package.json. I took this opportunity to use lockfileVersion: 2 which is the default if you use nodejs16

  3. Using firebase-admin v10.3.0 broke some unit test we had. Fixed in 2ee9549.

Copy link
Contributor

@kaibolay kaibolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taeold taeold merged commit c9c55cf into master Jul 15, 2022
@taeold taeold deleted the dl-cf3-seal-test branch July 15, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants