Skip to content

Update typedoc from 0.21.2 to ^0.23.7. #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

kaibolay
Copy link
Contributor

This should fix:

$ npm run build:pack

> firebase-functions@3.22.0 build:pack
> rm -rf lib && npm install && tsc -p tsconfig.release.json && npm pack

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: typedoc@0.21.2
npm ERR! Found: typescript@4.6.3
npm ERR! node_modules/typescript
npm ERR!   dev typescript@"^4.3.5" from the root project
npm ERR!   typescript@"~4.6.3" from @microsoft/api-extractor@7.23.0
npm ERR!   node_modules/@microsoft/api-extractor
npm ERR!     dev @microsoft/api-extractor@"^7.18.7" from the root project
npm ERR!   4 more (ts-node, tslint, tsutils, tsutils)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"4.0.x || 4.1.x || 4.2.x || 4.3.x" from typedoc@0.21.2
npm ERR! node_modules/typedoc
npm ERR!   dev typedoc@"0.21.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: typescript@4.3.5
npm ERR! node_modules/typescript
npm ERR!   peer typescript@"4.0.x || 4.1.x || 4.2.x || 4.3.x" from typedoc@0.21.2
npm ERR!   node_modules/typedoc
npm ERR!     dev typedoc@"0.21.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@kaibolay
Copy link
Contributor Author

This issue is addressed with #1170

@kaibolay kaibolay closed this Jul 15, 2022
@kaibolay kaibolay deleted the update-typedoc branch July 15, 2022 20:57
taeold added a commit that referenced this pull request Jul 15, 2022
Our `package-lock.json` file is outdated and our dependencies are a bit jumbled up.

I didn't notice any issue when using `nodejs14` but when using `nodejs16` reveals several issues that I've tried to address in the PR:

1. Update `typedoc` dependency to avoid impossible dep resolution (first reported #1169)

2. Regenerate `package-lock.json`. Looks like it's "behind" package.json. I took this opportunity to use `lockfileVersion: 2` which is the default if you use `nodejs16`

3. Using `firebase-admin` v10.3.0 broke some unit test we had. Fixed in 2ee9549.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant