Skip to content

[Plugins] Fix broken bundle test #7089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Plugins] Fix broken bundle test #7089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/src/test/kotlin/com/google/firebase/gradle/plugins/GenerateTutorialBundleTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class GenerateTutorialBundleTests : FunSpec() {
"com.google.firebase:firebase-analytics:1.2.4",
"com.google.firebase:firebase-crashlytics:12.0.0",
"com.google.firebase:firebase-perf:10.2.3",
"com.google.firebase:firebase-vertexai:9.2.3",
"com.google.firebase:firebase-ai:9.2.3",
),
gradlePlugins =
listOf(
Expand Down Expand Up @@ -82,8 +82,8 @@ class GenerateTutorialBundleTests : FunSpec() {
<!ENTITY crashlytics-dependency "com.google.firebase:firebase-crashlytics:12.0.0">
<!-- Performance Monitoring -->
<!ENTITY perf-dependency "com.google.firebase:firebase-perf:10.2.3">
<!-- Vertex AI in Firebase -->
<!ENTITY vertex-dependency "com.google.firebase:firebase-vertexai:9.2.3">
<!-- Firebase AI Logic -->
<!ENTITY firebase-ai-dependency "com.google.firebase:firebase-ai:9.2.3">
Comment on lines +85 to +86
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change replaces vertex-dependency with firebase-ai-dependency. Ensure that this is the correct entity and that firebase-ai-dependency is the intended replacement.

Suggested change
<!-- Firebase AI Logic -->
<!ENTITY firebase-ai-dependency "com.google.firebase:firebase-ai:9.2.3">
<!ENTITY firebase-ai-dependency "com.google.firebase:firebase-ai:9.2.3">


<!-- Firebase Gradle plugins -->
<!-- App Distribution -->
Expand Down
Loading