[Plugins] Fix broken bundle test #7089
Conversation
The test still verifies that vertex is generated when it should be firebase-ai instead.
Firebase AI Mock Responses Check
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @rlazo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a broken test within the plugins module. The test was failing because it was asserting against an outdated dependency name (firebase-vertexai) when the correct dependency name should be firebase-ai. The changes update the test's expectations to align with the current dependency naming, ensuring the test passes as intended.
Highlights
- Test Fix: Updated the
GenerateTutorialBundleTests.ktto correctly reference thefirebase-aidependency instead offirebase-vertexai. - Dependency Name Update: Corrected the expected artifact ID and associated XML entity definition within the test file from
firebase-vertexaitofirebase-ai.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| <!-- Firebase AI Logic --> | ||
| <!ENTITY firebase-ai-dependency "com.google.firebase:firebase-ai:9.2.3"> |
There was a problem hiding this comment.
This change replaces vertex-dependency with firebase-ai-dependency. Ensure that this is the correct entity and that firebase-ai-dependency is the intended replacement.
| <!-- Firebase AI Logic --> | |
| <!ENTITY firebase-ai-dependency "com.google.firebase:firebase-ai:9.2.3"> | |
| <!ENTITY firebase-ai-dependency "com.google.firebase:firebase-ai:9.2.3"> |
plugins test results68 tests 68 ✅ 1m 10s ⏱️ Results for commit 6004cab. |
Test Results 1 058 files ±0 1 058 suites ±0 35m 58s ⏱️ +17s For more details on these failures, see this check. Results for commit 6004cab. ± Comparison against base commit c12b5d1. |
Size Report 1Affected ProductsNo changes between base commit (c12b5d1) and merge commit (6b59d95).Test Logs |
Coverage Report 1Affected Products
Test Logs |
The test still verifies that vertex is generated when it should be firebase-ai instead.