Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing SSRC Typos and Minor Bugs #841

Merged
merged 46 commits into from
Jan 8, 2025
Merged

Fixing SSRC Typos and Minor Bugs #841

merged 46 commits into from
Jan 8, 2025

Conversation

pijushcs
Copy link

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@pijushcs pijushcs marked this pull request as draft December 18, 2024 14:02
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Overall LGTM!

Left a few comments

firebase_admin/remote_config.py Outdated Show resolved Hide resolved
firebase_admin/remote_config.py Outdated Show resolved Hide resolved
firebase_admin/remote_config.py Show resolved Hide resolved
Copy link

@nithya-krishnan nithya-krishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared a few comments.

@pijushcs pijushcs removed the request for review from nithya-krishnan January 7, 2025 06:48
@pijushcs pijushcs marked this pull request as ready for review January 7, 2025 06:48
jonathanedey and others added 24 commits January 8, 2025 21:10
* Added multi db support for firestore and firestore_async

* Added unit and integration tests

* fix docs strings
Add dependabot support to the repo
…app()` (#821)

* feat: Support passing `google.auth` typed credentials in `initialize_app()`

* Refactor and add unit test
…e Multi Database (#827)

* feat(firestore): Upgrade `google-cloud-firestore` to support Firestore Multi Database

* Bump to v2.19.0
…to 3.9 (#840)

* chore: Skip integration test for deprecated FCM API

* chore: Bump pypy test version to 3.9
* Adding delayed response message for holidays

* fix date
* Initial Skeleton for SSRC Implementation

* Adding Implementation for RemoteConfigApiClient and ServerTemplate APIs

* Updating API signature

* Minor update to API signature

* Adding comments and unit tests

* Updating init params for ServerTemplateData

* Adding validation errors and test

* Adding unit tests for init_server_template and get_server_template

* Removing parameter groups

* Addressing PR comments and fixing async flow during fetch call

* Fixing lint issues

---------

Co-authored-by: Pijush Chakraborty <pijushc@google.com>
…e Remote Config (#824)

* Added implemenation of evaluate function

* Improvement

* Add farmhash to extension whitelist pkg

* Replace farmhash to hashlib

* Added unit testcase

* removed lint error

* add mock test

* resolve lint comments

* Fixed bug

* Added fixes

* Added fixe

* Added fix for lint

* Changed structure of test

* Added fix for comments

* Added fix for comments

---------

Co-authored-by: Varun Rathore <varunrathore@google.com>
…thon into ssrc-bug-bash

Integrating with changes in master
@pijushcs pijushcs merged commit 065424a into ssrc Jan 8, 2025
12 checks passed
@pijushcs pijushcs deleted the ssrc-bug-bash branch January 8, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants