-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing SSRC Typos and Minor Bugs #841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added multi db support for firestore and firestore_async * Added unit and integration tests * fix docs strings
Add dependabot support to the repo
…app()` (#821) * feat: Support passing `google.auth` typed credentials in `initialize_app()` * Refactor and add unit test
…e Multi Database (#827) * feat(firestore): Upgrade `google-cloud-firestore` to support Firestore Multi Database * Bump to v2.19.0
…to 3.9 (#840) * chore: Skip integration test for deprecated FCM API * chore: Bump pypy test version to 3.9
lahirumaramba
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Overall LGTM!
Left a few comments
* Adding delayed response message for holidays * fix date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared a few comments.
nithya-krishnan
approved these changes
Jan 7, 2025
* Added multi db support for firestore and firestore_async * Added unit and integration tests * fix docs strings
Add dependabot support to the repo
…app()` (#821) * feat: Support passing `google.auth` typed credentials in `initialize_app()` * Refactor and add unit test
…e Multi Database (#827) * feat(firestore): Upgrade `google-cloud-firestore` to support Firestore Multi Database * Bump to v2.19.0
…to 3.9 (#840) * chore: Skip integration test for deprecated FCM API * chore: Bump pypy test version to 3.9
* Adding delayed response message for holidays * fix date
* Initial Skeleton for SSRC Implementation * Adding Implementation for RemoteConfigApiClient and ServerTemplate APIs * Updating API signature * Minor update to API signature * Adding comments and unit tests * Updating init params for ServerTemplateData * Adding validation errors and test * Adding unit tests for init_server_template and get_server_template * Removing parameter groups * Addressing PR comments and fixing async flow during fetch call * Fixing lint issues --------- Co-authored-by: Pijush Chakraborty <pijushc@google.com>
…e Remote Config (#824) * Added implemenation of evaluate function * Improvement * Add farmhash to extension whitelist pkg * Replace farmhash to hashlib * Added unit testcase * removed lint error * add mock test * resolve lint comments * Fixed bug * Added fixes * Added fixe * Added fix for lint * Changed structure of test * Added fix for comments * Added fix for comments --------- Co-authored-by: Varun Rathore <varunrathore@google.com>
…thon into ssrc-bug-bash Integrating with changes in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.