-
Couldn't load subscription status.
- Fork 344
Implementation for Evaluating Condition and Custom Signals Server Side Remote Config #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
To over-communicate, I'm approving this from the perspective of someone familiar with this feature. I expect this change will also be reviewed by an Admin SDK platform owner before merging into the main branch.
…e Remote Config (#824) * Added implemenation of evaluate function * Improvement * Add farmhash to extension whitelist pkg * Replace farmhash to hashlib * Added unit testcase * removed lint error * add mock test * resolve lint comments * Fixed bug * Added fixes * Added fixe * Added fix for lint * Changed structure of test * Added fix for comments * Added fix for comments --------- Co-authored-by: Varun Rathore <varunrathore@google.com>
…e Remote Config (#824) * Added implemenation of evaluate function * Improvement * Add farmhash to extension whitelist pkg * Replace farmhash to hashlib * Added unit testcase * removed lint error * add mock test * resolve lint comments * Fixed bug * Added fixes * Added fixe * Added fix for lint * Changed structure of test * Added fix for comments * Added fix for comments --------- Co-authored-by: Varun Rathore <varunrathore@google.com>
…e Remote Config (#824) * Added implemenation of evaluate function * Improvement * Add farmhash to extension whitelist pkg * Replace farmhash to hashlib * Added unit testcase * removed lint error * add mock test * resolve lint comments * Fixed bug * Added fixes * Added fixe * Added fix for lint * Changed structure of test * Added fix for comments * Added fix for comments --------- Co-authored-by: Varun Rathore <varunrathore@google.com>
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.