-
Couldn't load subscription status.
- Fork 344
fix(auth): adds missing EMAIL_NOT_FOUND error code #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -444,6 +444,7 @@ def generate_password_reset_link(self, email, action_code_settings=None): | |
|
|
||
| Raises: | ||
| ValueError: If the provided arguments are invalid | ||
| EmailNotFoundError: If no user exists by the specified email address. | ||
| FirebaseError: If an error occurs while generating the link | ||
| """ | ||
| return self._user_manager.generate_email_action_link( | ||
|
|
@@ -464,6 +465,7 @@ def generate_email_verification_link(self, email, action_code_settings=None): | |
|
|
||
| Raises: | ||
| ValueError: If the provided arguments are invalid | ||
| UserNotFoundError: If no user exists by the specified email address. | ||
|
||
| FirebaseError: If an error occurs while generating the link | ||
| """ | ||
| return self._user_manager.generate_email_action_link( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason to use "by" here?
I'd expect "for" probably, here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching. I copied and pasted blindly. It is fixed now here and elsewhere.