fix(auth): adds missing EMAIL_NOT_FOUND error code

[bojeil-google]

Catch EMAIL_NOT_FOUND and translate to EmailNotFoundError when /accounts:sendOobCode is called for password reset on a user that does not exist.

[lahirumaramba]

Thank you @bojeil-google !
LGTM. Please add a TW to review the reference doc changes.

[hiranya911]

One possible typo. Can we also add a test case? Similar to:

firebase-admin-python/tests/test_user_mgt.py

Line 286 in ebf0961

def test_get_user_non_existing(self, user_mgt_app):

[hiranya911]

Should be EmailNotFoundError?

[bojeil-google]

Unfortunately, this is the problem. They throw different errors. For password reset, they throw EMAIL_NOT_FOUND. For email verification, they throw USER_NOT_FOUND.

[hiranya911]

Ah, fair enough 👍

[bojeil-google]

One possible typo. Can we also add a test case? Similar to:

firebase-admin-python/tests/test_user_mgt.py

Line 286 in ebf0961

def test_get_user_non_existing(self, user_mgt_app):

Done

[hiranya911]

Thanks. LGTM!

[egilmorez]

LG, one tiny nit.

[egilmorez]

Is there a specific reason to use "by" here?

I'd expect "for" probably, here and below.

[bojeil-google]

Thanks for catching. I copied and pasted blindly. It is fixed now here and elsewhere.