Skip to content

fix(auth): Updates d.ts definition for setCustomUserClaims to allow nulls for custom user claims #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

bojeil-google
Copy link
Contributor

@bojeil-google bojeil-google commented Oct 7, 2019

Updates d.ts definition for setCustomUserClaims to allow nulls for custom user claims.
Passing null will clear existing claims.
Added integration tests for clearing custom claims.

Resolves #667

RELEASE NOTE: Updated the typings of the setCustomUserClaims() API to accept null.

custom user claims.
Passing null will clear existing claims.
Added integration tests for clearing custom claims.
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bojeil-google bojeil-google merged commit 2bae77b into master Oct 7, 2019
@hiranya911 hiranya911 changed the title Updates d.ts definition for setCustomUserClaims to allow nulls for custom user claims fix(auth): Updates d.ts definition for setCustomUserClaims to allow nulls for custom user claims Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] setCustomUserClaims declaration doesn't match documentation
2 participants