Skip to content

Conversation

@justinattw
Copy link

Based on (and requires first merging of) #737
Closes #736

https://firebase.google.com/docs/reference/fcm/rest/v1/ErrorCode specifies that google.rpc.QuotaFailure is returned with FCM.

We can expose this via a public API GetQuotaFailure(err *errorutils.FirebaseError) *QuotaFailure method.

I also refactored the messaging.go error-related code bits into messaging_errors.go.

@gemini-code-assist
Copy link

Summary of Changes

Hello @justinattw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors and enhances error handling within the Firebase Admin Go SDK. It introduces a structured way to parse and expose detailed quota failure information from FCM responses, centralizes common error types and utilities into a new public package, and improves the internal organization of the messaging client's error logic. These changes aim to provide developers with more granular and actionable error insights while maintaining an idiomatic Go experience.

Highlights

  • Enhanced FCM Error Reporting: Introduced a new QuotaFailure type and GetQuotaFailure function in the messaging package to provide detailed information about google.rpc.QuotaFailure errors returned by FCM, such as specific quota violations.
  • Public Error Utilities Package: Refactored the core FirebaseError type, ErrorCode constants, and common error-checking utility functions into a new, public errorutils package, improving modularity and reusability across the SDK.
  • Messaging Error Code Refactoring: Moved all FCM-specific error codes and error handling logic from messaging.go to a new dedicated file, messaging_errors.go, enhancing code organization within the messaging package.
  • Copyright Updates: Updated copyright notices across numerous files from 'Google Inc.' to 'Google LLC' for consistency.
  • AI Agent Guide Added: A new AGENTS.md file has been added, providing comprehensive guidelines for AI agents contributing to the Firebase Admin Go SDK, covering conventions, design patterns, and architecture.
  • FirebaseError Field Renamed: The String field within the FirebaseError struct has been renamed to Message for improved clarity and consistency in error reporting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/nightly.yml
    • .github/workflows/release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for QuotaFailure errors in FCM and significantly refactors the error handling logic across the SDK. The core error types and helper functions have been moved from an internal package to a new public errorutils package, which is a great improvement for SDK users. The new QuotaFailure parsing logic for FCM errors is well-implemented and comes with thorough tests.

Overall, the changes are well-structured and improve the SDK's error handling capabilities. I've only found a couple of minor typos in the newly added AGENTS.md documentation file.

@justinattw justinattw closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide an interface for getting the cause of QUOTA_EXCEEDED

3 participants