-
Notifications
You must be signed in to change notification settings - Fork 271
Add QuotaFailure to the FirebaseError
#738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QuotaFailure to the FirebaseError
#738
Conversation
…ct with this repository (firebase#710)
* fix(auth): Fixed auth error code parsing * fix(auth): Fixed test to use error message prefix
Summary of ChangesHello @justinattw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors and enhances error handling within the Firebase Admin Go SDK. It introduces a structured way to parse and expose detailed quota failure information from FCM responses, centralizes common error types and utilities into a new public package, and improves the internal organization of the messaging client's error logic. These changes aim to provide developers with more granular and actionable error insights while maintaining an idiomatic Go experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for QuotaFailure errors in FCM and significantly refactors the error handling logic across the SDK. The core error types and helper functions have been moved from an internal package to a new public errorutils package, which is a great improvement for SDK users. The new QuotaFailure parsing logic for FCM errors is well-implemented and comes with thorough tests.
Overall, the changes are well-structured and improve the SDK's error handling capabilities. I've only found a couple of minor typos in the newly added AGENTS.md documentation file.
Based on (and requires first merging of) #737
Closes #736
https://firebase.google.com/docs/reference/fcm/rest/v1/ErrorCode specifies that
google.rpc.QuotaFailureis returned with FCM.We can expose this via a public API
GetQuotaFailure(err *errorutils.FirebaseError) *QuotaFailuremethod.I also refactored the
messaging.goerror-related code bits intomessaging_errors.go.