-
Notifications
You must be signed in to change notification settings - Fork 271
Make FirebaseError publicly accessible
#737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @justinattw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the usability of the Firebase Admin Go SDK by making its core error type, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully makes the FirebaseError type and related error-checking functions publicly accessible by moving them to the errorutils package. The changes are well-structured, and the addition of a comprehensive test suite for the new public API is a great inclusion. My review includes a suggestion to improve the public API of FirebaseError by renaming a field for better clarity, which is best done now as it's being exposed. I've also pointed out a couple of minor typos in comments. I've provided code suggestions for all changes within the diff.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great step towards improving the public API of the SDK. Moving FirebaseError to a public package errorutils and renaming the String field to Message for idiomatic Go are excellent changes. The aliasing in the internal package ensures backward compatibility, which is well thought out.
I have one suggestion to further improve the new errorutils package by using errors.As for more robust error handling, which will be very beneficial for developers using this library. The rest of the changes look good.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Closes #576, towards #736
Allow integrators to access the
FirebaseErrorby moving it frominternal/errors.gotoerrorutils/errorutils.go, so that it is no longer internal only.internal/errors.gowill alias fromerrorutils/errorutils.go.This brings feature parity with the Python library firebase/firebase-admin-python
Also, updates
FirebaseError.StringtoFirebaseError.Message, as.Stringis not idiomatic for an error message in Go (#737 (review)).