The Big Kahuna #390
Merged
The Big Kahuna #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia8969fe42c84ada6fb2fde826d6b768dd63b5ab4
SmartLock Deletion
Change-Id: I7bcb4660aa7c69ba36fd1d36df73fb457ac56c56
Check for null password or lack of network
…droid into version-1.0.0-dev
Change-Id: I1a1544d88a3fab9d5ea9b3293e4b2efb6c664aac
Update README.md
Change-Id: I09194ea6d170f8d1fa0aa0d7d8e7d20367e55aba
Specify additonal scopes through code rather than config.xml
This exposes the IdpResponse object to the user. It can be retrieved from the result intent received in onActivityResult using IdpResponse.fromResultIntent(data). Resolves #286.
Flip incorrect assertEquals statements
Resolves issue #361
* temporary: saving to work on another computer won't compile * Code compiles * Cleanup * Cleanup * Cleanup * Update SmartLock.java with new fragment logic * Fix bug in SmartLock.java * Cleanup * Cleanup * Fix broken tests * Cleanup * Cleanup * Cleanup * Bug fix * Cleanup * Add interface to SmartLock * Merge dev * working on tests * working on tests * Revert interface, working on fixing tests * Fix tests * Merge dev * Fix merge mistakes * Cleanup * Final cleanup and fix tests * Fix test * Fix test
* Better facebook error handling * review feedback
* add support for a dark theme * fix for text color propagation * set the edit text color
Don't silently fail if Google Sign In fails #182
Add Facebook and Twitter to Smartlock read #171
Better logging when IDP login fails.
Add Twitter Warning about Consumer Secret
Remove unused save credentials layout
* Various bugfixes for 1.0 * Review feedback and fix tests * Fix a few mistakes
* Fixes for older Android devices * fix/rework SmartLock tests * review feedback * Fix tests * fix more tests
* Fix for unknown auth code * Fix for Facebook login crash in chrome custom tab * make callback manager static * clean up for review * add some more logging * review feedback
* Update FirebaseArray to support joined data * Update FirebaseRecyclerAdapter to support joined data * Refactor setOnChangedListener * Update FirebaseListAdapter to support joined data * Refactor setOnChangedListener * Update README.md * Handle key not found at dataRef * Handle onCancelled * Handle onCancelled * Handle onCancelled * Update FirebaseArray.java * Update FirebaseArray.java * Update FirebaseListAdapter.java * Update FirebaseRecyclerAdapter.java * Update FirebaseArray.java * Update FirebaseListAdapter.java * Log a warning instead of exception if key is missing * Extract indexed array into separate class * Fix formatting * Fix formatting * Fix formatting * Refactor adapters * Fix IndexOutOfBoundsException and list item not being removed * Make getIndexForKey available to implementations * Code cleanup and optimizations * Add copyright * Update FirebaseRecyclerAdapter.java * Re-architected IndexFirebaseArray * Fix Intellij's annoying obsession with putting interfaces at the bottom of a class * Update IndexFirebaseArray.java * Fix "key not found" exception when a key from the key ref has a null value in the data ref location. * Extract FirebaseIndexListAdapter * Cleanup for final review * Cleanup for final review * Update FirebaseArray.java * Refactoring of IndexFirebaseArray * Update README.md * Improved cleanup speed. * Renames * Handle case when dataSnapshot value is null * Update IndexFirebaseArray.java * Renamed to FirebaseIndexArray * Cleanup * Fixed condition in isMatch method * Tweaks * Add back supers * Update FirebaseArray.java * Make life compile * Update FirebaseArray.java * Fix package statements moving around * Cleanup * Add clearer error logging * Updated documentation * Even clearer * Relax query requirements and remove unnecessary constructors. * fix typo * tests part 1 * test travis should fail * tests part 2 * Remove unnecessary constructor * Fix typo * Fix nits
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@samstern It's happening!!! 😃 |
|
Ohhhhh yeah. @amandle is doing some final tests, but it's definitely happening imminently. |
|
Down to 30 issues!!! 🎉 The repo is so clean now! 🎉 1.0.0! 🍰 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the big one! Requesting 1.0 --> Master