Add Twitter as an IDP #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,5 +80,9 @@ | |||
| </intent-filter> | |||
| </activity> | |||
|
|
|||
| <meta-data | |||
| android:name="io.fabric.ApiKey" | |||
There was a problem hiding this comment.
Is this actually necessary? In the Firebase Auth quickstart I was able to get Twitter Sign In to work with only the consumer key/secret and didn't need the app ID or any meta-data:
https://github.com/firebase/quickstart-android/blob/master/auth/app/src/main/AndroidManifest.xml
There was a problem hiding this comment.
You're right, it doesn't appear to be necessary. Removed it.
|
@amandle this looks really good! We do need to wait for iOS to release but I think we can still do work like this on a |
| @@ -229,6 +245,17 @@ private boolean isFacebookConfigured() { | |||
| } | |||
|
|
|||
| @MainThread | |||
| private boolean isTwitterConfigured() { | |||
| List<String> twitterConfigs = Arrays.asList( | |||
| getResources().getString(R.string.twitter_app_id), | |||
There was a problem hiding this comment.
Missed one reference to twitter_app_id
|
LGTM, thanks! |
This was referenced Aug 26, 2016
samtstern
pushed a commit
to samtstern/FirebaseUI-Android
that referenced
this pull request
Sep 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Twitter as a provider in response to issue #157
I am not entirely sure how this will fit in with our feature parity plans with other platforms, we may have to wait for iOS to implement it before we can actually release.
Also, the Twitter Client Secret is stored in a resources file, which is not ideal but without writing a custom back-end server to coordinate with I'm not sure there is a better alternative (just obfuscation techniques) though I'm open to any suggestions.