Skip to content

Update Support Library Version #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samtstern merged 2 commits into from
Feb 28, 2018
Merged

Update Support Library Version #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a381e13
Remove deprecated references from README (#1173)
SUPERCILEX Feb 27, 2018
6abafd1
Update Support Library Version
majid-vaghari Feb 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions auth/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,6 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
if (resultCode == RESULT_OK) {
startActivity(SignedInActivity.createIntent(this, response));
finish();
return;
} else {
// Sign in failed
if (response == null) {
Expand All @@ -349,20 +348,16 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
return;
}

if (response.getErrorCode() == ErrorCodes.NO_NETWORK) {
if (response.getError().getErrorCode() == ErrorCodes.NO_NETWORK) {
showSnackbar(R.string.no_internet_connection);
return;
}

if (response.getErrorCode() == ErrorCodes.UNKNOWN_ERROR) {
showSnackbar(R.string.unknown_error);
return;
}

showSnackbar(R.string.unknown_error);
Log.e(TAG, "Sign-in error: ", response.getError());
}

showSnackbar(R.string.unknown_sign_in_response);
}
}
}
```

Alternatively, you can register a listener for authentication state changes;
Expand Down
2 changes: 1 addition & 1 deletion constants.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ project.ext {
minSdk = 14

firebaseVersion = '11.8.0'
supportLibraryVersion = '27.0.2'
supportLibraryVersion = '27.1.0'
architectureVersion = '1.1.0'
kotlinVersion = '1.2.21'
}