Skip to content

Update Support Library Version#1174

Merged
samtstern merged 2 commits intofirebase:version-3.3.0-devfrom
majid-vaghari:patch-1
Feb 28, 2018
Merged

Update Support Library Version#1174
samtstern merged 2 commits intofirebase:version-3.3.0-devfrom
majid-vaghari:patch-1

Conversation

@majid-vaghari
Copy link
Contributor

Support Library is updated to version 27.1.0 on February 2018 and I think FirebaseUI should update its dependency. In my current project updating support library results in "Unable to merge dex". Please upgrade and release a new version as soon as possible.

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • Read the contribution guidelines.
  • Run ./gradlew check to ensure the Travis build passes.
  • If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
  • If this is a new feature please co-ordinate with someone on FirebaseUI-iOS to make sure that we can implement this on both platforms and maintain feature parity.

SUPERCILEX and others added 2 commits February 27, 2018 12:20
Support Library is updated to version 27.1.0 on February 2018 and I think FirebaseUI should update its dependency. In my current project updating support library results in "Unable to merge dex". Please upgrade and release a new version as soon as possible.
@googlebot
Copy link

Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@majid-vaghari
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@samtstern samtstern changed the base branch from master to version-3.3.0-dev February 28, 2018 15:52
@samtstern samtstern added this to the 3.3.0 milestone Feb 28, 2018
@samtstern
Copy link
Contributor

@majid-vaghari I will add this to the 3.3.0 release, thanks!

If you're having dex issues now, I am happy to help.

@samtstern samtstern merged commit b7a3b7f into firebase:version-3.3.0-dev Feb 28, 2018
@majid-vaghari majid-vaghari deleted the patch-1 branch March 3, 2018 00:22
@majid-vaghari
Copy link
Contributor Author

Thank you @samtstern. I changed the version of support library back to 27.0.2 in my own project. The problem seems to be originating from the fact that firebase-ui-auth:3.2.2 depends on support library 27.0.2 so if my project has a dependency on both support library 27.1.0 and firebase-ui-auth:3.2.2, Gradle apparently cannot resolve them well. I tried to go around this by telling Gradle not to include support library when I'm specifying dependency on firebaseui. Something similar to this:

dependencies {
    implementation 'com.android.support:design:27.1.0' // and some other packages from support library
    implementation ('com.firebaseui:firebase-ui-auth:3.2.2') {
        exclude group: 'com.android.support'
    }
}

But it didn't seem to work. Inevitably I downgraded the support library version back to 27.0.2 and the build process completed successfully.

If there is another workaround which you may know of, I would be glad to hear it from you.

@samtstern
Copy link
Contributor

@majid-vaghari here's the general workaround:
https://github.com/firebase/FirebaseUI-Android#upgrading-dependencies

So you'd want to add:

implementation "com.android.support:design:27.1.0"
implementation "com.android.support:customtabs:27.1.0"
implementation "com.android.support:cardview-v7:27.1.0"

By explicitly adding those to your own build.gradle it tells gradle that you want to override the transitive dependency of firebase-ui-auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants