fix: various errors and logs #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipdutescu
force-pushed
the
fix/empty_word_rename_error
branch
from
3cb378a
to
b562850
Compare
filipdutescu
changed the title
filipdutescu
force-pushed
the
fix/empty_word_rename_error
branch
4 times, most recently
from
b4a9937
to
dd25890
Compare
Prevent the popup from being drawn if the cursor is on an empty space and log a debug message regarding it. Add `lua/renamer/constants.lua` to store all reused hardcoded strings and any other strings that should be managed in a proper way. Closes: GH-95 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prevent the popup from being drawn if the cursor is on an empty space and log a debug message regarding it.
Add
lua/renamer/constants.luato store all reused hardcoded strings and any other strings that should be managed in a proper way.Closes: GH-95
Proposed changes
lua/renamer/constants.luarenamer.rename()to not allow renaming on empty strings, such as ' 'Test plan
Existing tests are updated and a new one is added to validate the new behaviour.