Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Error when attempting to rename empty space #95

Closed
EtiamNullam opened this issue Nov 26, 2021 · 1 comment · Fixed by #97
Closed

[Bug] Error when attempting to rename empty space #95

EtiamNullam opened this issue Nov 26, 2021 · 1 comment · Fixed by #97
Assignees
@filipdutescu
Labels
bug Something isn't working
Milestone
3.0.3

Comments

@EtiamNullam
Copy link

Describe the bug

Invoking rename method will throw this error when you attempt it on empty space:

E5108: Error executing lua ~\.vim-plug\renamer.nvim/lua/renamer/init.lua:129: attempt to perform arithmetic on local 'word_start' (a nil value)
stack traceback:
	~\.vim-plug\renamer.nvim/lua/renamer/init.lua:129: in function 'rename'
	[string ":lua"]:1: in main chunk

To reproduce

Steps to reproduce the behavior:

  1. Place cursor on space or newline.
  2. Run lua require('renamer').rename().
  3. See error.

Expected behavior

There should be short and less distracting message displayed instead.

Environment

  • Renamer: v3.0.2
  • Neovim: v0.5.1
  • OS: Windows, version: 10
@EtiamNullam EtiamNullam added the bug Something isn't working label Nov 26, 2021
@filipdutescu filipdutescu self-assigned this Nov 26, 2021
@filipdutescu filipdutescu added this to the 3.0.3 milestone Nov 26, 2021
@filipdutescu
Copy link
Owner

Thanks for submitting the two issues, good catches as well! Will come with a fix this weekend.

filipdutescu added a commit that referenced this issue Nov 29, 2021
@filipdutescu
fix: various erros and logs
3cb378a 
TODO

Closes: GH-95
Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
@filipdutescu filipdutescu mentioned this issue Nov 29, 2021
Merged
filipdutescu added a commit that referenced this issue Nov 29, 2021
@filipdutescu
fix: various erros and logs
b562850 
TODO

Closes: GH-95
Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
filipdutescu added a commit that referenced this issue Nov 29, 2021
@filipdutescu
fix: various errors and logs
1fbc666 
TODO

Closes: GH-95
Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
filipdutescu added a commit that referenced this issue Nov 29, 2021
@filipdutescu
fix: various errors and logs
16bfaea 
Prevent the popup from being drawn if the cursor is on an empty space
and log a debug message regarding it.

Add `lua/renamer/constants.lua` to store all reused hardcoded strings
and any other strings that should be managed in a proper way.

Closes: GH-95
Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
filipdutescu added a commit that referenced this issue Nov 29, 2021
@filipdutescu
fix: various errors and logs
b4a9937 
Prevent the popup from being drawn if the cursor is on an empty space
and log a debug message regarding it.

Add `lua/renamer/constants.lua` to store all reused hardcoded strings
and any other strings that should be managed in a proper way.

Closes: GH-95
Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipdutescu filipdutescu

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.3
Development

Successfully merging a pull request may close this issue.

fix: various errors and logs filipdutescu/renamer.nvim
2 participants
@EtiamNullam @filipdutescu