Feature: Added setting to select files and folders on mouse hover

[ferrariofilippo]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Feature: Add setting to select files and folders when hovering over them with the mouse #3682

Validation
How did you test these changes?

• Built and ran the app

[yaira2]

Left some comments regarding spaces and property names but code looks code.

[yaira2]

LGTM

I did notice some issues where the items weren't selected but let's wait for the update ListView styles from WinUI before making this an issue.

[yaira2]

@gave92 do you want to look this over before I merge it?

[gave92]

Ok, I should be able to go over it later today.

[gave92]

Sorry @ferrariofilippo I've pushed more changes than I wanted to. I'm gonna revert most of them shortly.

Aside from that the functionality works well. Possible improvements:

• Selection does not work when hovering over "empty" spaces of an element (noticeable in Tiles view)

• To match explorer hover selection should consider whether Control or Shift key are pressed in order to extend the selection

[yaira2]

Selection does not work when hovering over "empty" spaces of an element (noticeable in Tiles view)

I think we should fix this before merging

[ferrariofilippo]

• Selection does not work when hovering over "empty" spaces of an element (noticeable in Tiles view)

It's a problem of DetailsLayout too.
I'll fix that

[ferrariofilippo]

I find out there's a problem when hovering an element's borders: PointerOver style is applied but PointerEntering event isn't raised

[yaira2]

I find out there's a problem when hovering an element's borders

This seems to happen pretty often 🤔

[ferrariofilippo]

I read MS (Windows.UI.Xaml.Controls) ListView docs, and I learnt it doesn't support any ItemHovered event: you can only set a style for hovered items. Because of this, you have to use PointerEntered event of child items, which gets invoked only when known limits.

[yaira2]

Can this be solved by adding a border control to the ListView item and adding the PointerEntered event on that? I don't think it'll have that big of a performance hit but we should check the difference on a large directory like system32.

[ferrariofilippo]

I'll try that

[ferrariofilippo]

I found a way of fixing PointerEntered area for TilesLayout. Now I'm working on DetailsLayout.
Other layouts are fine

[gave92]

I've pushed feee91f to propose a fix for hover on elements "empty space". It should work for all layout modes, with no need to change the xaml. Idea is to subscribe the pointer events on the ListViewItem container. What do you think?

[ferrariofilippo]

I think it's great. Thank you for the fix!
It works perfectly

[yaira2]

LGTM

[yaira2]

It appears that we need to listen when this property changes as well, otherwise the user needs to restart the app for the setting to take effect.

[gave92]

True. Refreshing the file list should be enough though.

[yaira2]

Can probably do the same thing we do when users change the setting to show hidden items.