Fixed: Right click doesn't always select the file/folder hovered over

[ferrariofilippo]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Bug: Right click doesn't always select the file/folder hovered over #9834

Comments
I changed RightTapped event-area, applying it to items' container (same as #9977 )
If you think this is ok, I'll proceed with code cleanup (remove nullable warnings)

Validation
How did you test these changes?

• Built and ran the app

[yaira2]

Looks good to me, assuming you tested with touch and the keyboard shortcut (I can test touch if you want).

[ferrariofilippo]

Looks good to me, assuming you tested with touch and the keyboard shortcut (I can test touch if you want).

Yes, please. I have no way of testing with touch, it would be great if you could help me with that

[yaira2]

I seem to be getting an unhandled exception even without touch on the grid layouts "--------- UNHANDLED EXCEPTION ---------\n>>>> HRESULT: -2147467262\n\n--- MESSAGE ---Unable to cast object of type 'Microsoft.UI.Xaml.Controls.GridViewItem' to type 'Microsoft.UI.Xaml.Controls.ListViewItem'.\n--- STACKTRACE --- at Files.App.BaseLayout.FileListItem_RightTapped(Object sender, RightTappedRoutedEventArgs e)\r\n at ABI.Microsoft.UI.Xaml.Input.RightTappedEventHandler.Do_Abi_Invoke(IntPtr thisPtr, IntPtr sender, IntPtr e)\r\n--- End of stack trace from previous location ---\r\n at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|20_0(Int32 hr)\r\n at ABI.Windows.ApplicationModel.Core.IUnhandledErrorMethods.Propagate(IObjectReference _obj)\r\n at Microsoft.AppCenter.Utils.ApplicationLifecycleHelperWinUI.<.ctor>b__0_3(Object sender, UnhandledErrorDetectedEventArgs eventArgs)\r\n--- End of stack trace from previous location ---\r\n at Microsoft.AppCenter.Utils.ApplicationLifecycleHelperWinUI.<.ctor>b__0_3(Object sender, UnhandledErrorDetectedEventArgs eventArgs)\r\n at ABI.System.EventHandler1.Do_Abi_Invoke[TAbi](Void* thisPtr, IntPtr sender, TAbi args)\n--- SOURCE ---System.Private.CoreLib---------------------------------------"

[ferrariofilippo]

I'll check

[yaira2]

List view looks good though 👍

[ferrariofilippo]

Anyway, I'm not sure about the keyboard right-click behaviour.
Let me explain: if I'm navigating using the keyboard I'll expect to open the context menu of the selected item, not the hovered one. If you left the mouse over an item, opening the context menu would open the one of the file hovered and it would be annoying.

[yaira2]

I agree, I meant to test that it still worked for the selected item 👍

[ferrariofilippo]

I agree, I meant to test that it still worked for the selected item 👍

Ok

[yaira2]

This is a really nice change! LGTM