Skip to content

Fix: Fixed issue where turning off grouping can show an empty view #9961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Validation

  • Built and ran the app

@yaira2 yaira2 changed the title Fixed: Turning off grouping can show an empty view #5011 Fixed: Turning off grouping can show an empty view Sep 9, 2022
@ferrariofilippo ferrariofilippo force-pushed the Bug_Turning_Off_Groups_#5011 branch from a9dacf4 to f9230c0 Compare September 16, 2022 20:31
@yaira2 yaira2 changed the title Fixed: Turning off grouping can show an empty view Fix: Fixed issue where turning off grouping can show an empty view Oct 3, 2022
@yaira2 yaira2 requested a review from d2dyno1 October 12, 2022 15:31
@d2dyno1
Copy link
Member

d2dyno1 commented Oct 14, 2022

It's hard to determine what changes were made if spacing is changed (tabs/spaces). I'd advise change the spacing in a separate PR because it can also quickly result in merge conflicts

@yaira2
Copy link
Member

yaira2 commented Oct 14, 2022

@d2dyno1 you can hide whitespace changes
image

@d2dyno1
Copy link
Member

d2dyno1 commented Oct 14, 2022

@ferrariofilippo Could you recreate this PR without whitespace changes to avoid conflicts?

@yaira2
Copy link
Member

yaira2 commented Oct 14, 2022

It's probably best to keep the pr open and just resolve conflicts.

@ferrariofilippo
Copy link
Contributor Author

It's hard to determine what changes were made if spacing is changed (tabs/spaces). I'd advise change the spacing in a separate PR because it can also quickly result in merge conflicts

I added the method private void ZoomIn(object sender, GroupOption option) in all layouts

@yaira2
Copy link
Member

yaira2 commented Oct 14, 2022

Is that something that can be done in base layout?

@ferrariofilippo
Copy link
Contributor Author

We can't since ZoomIn needs a control from the xaml (RootGrid name of SemanticZoom control)

@yaira2
Copy link
Member

yaira2 commented Oct 20, 2022

@d2dyno1 the conflicts have been resolved, can you take a look again?

@yaira2 yaira2 merged commit 7a5262f into files-community:main Oct 20, 2022
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 20, 2022
@yaira2
Copy link
Member

yaira2 commented Oct 20, 2022

Thank you

@ferrariofilippo ferrariofilippo deleted the Bug_Turning_Off_Groups_#5011 branch October 20, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Turning off grouping can show an empty view
3 participants