Bug: Turning off grouping can show an empty view

[nvi9]

Explain the bug

When grouping (implemented in #4826) is turned on and the user clicks on a header to show the group names only and then turns off grouping the view becomes empty.

To reproduce

1. Go to any folder
2. Click on Arrangement options
3. Select any grouping type (eg. Name)
4. Click on a group header
5. Click on Arrangement options again
6. Select None in the Group by options
7. See the error (empty view)

Expected behavior

The original folder view should be restored when Group by > None is being selected.

Screenshots

System Information

• OS Version: Windows 10 20H2 19042.985
• App version: 2.3.11.0

Additional comment

This is not an issue when the folder contents were visible, not just the group headers.

By the way sorry for my misunderstanding, but how did you find this feature? I have no idea running the version 1.5.0. I even look up the Release notes and couldn't find any mentions about it.

[winston-de]

By the way sorry for my misunderstanding, but how did you find this feature? I have no idea running the version 1.5.0. I even look up the Release notes and couldn't find any mentions about it.

@LukoFoks This feature has yet to be released, and can only be found by building the source code from main.

[MarkBirkholz]

Looks like it is necessary to call ToggleActiveView (to turn off zoom mode) when IsSourceGrouped is set to false. Either in the DetailsLayoutBrowser config or somewhere here https://github.com/files-community/Files/blob/main/Files/ViewModels/ItemViewModel.cs#L657.
(Sorry, i'm new to this project)

[yaira2]

@nvi9 is this still an issue in v2.1.13?

[nvi9]

@nvi9 is this still an issue in v2.1.13?

@yaichenbaum yes it is