Skip to content

Feature: Added option to double click to open folders in column layout #9932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 6, 2022
Merged

Feature: Added option to double click to open folders in column layout #9932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51829c9
Feature: Support double click in the column layout #9704
ferrariofilippo Sep 6, 2022
69e0c65
Added Setting
ferrariofilippo Sep 6, 2022
4207519
Cleaned up code
yaira2 Sep 6, 2022
d2beec9
CC
yaira2 Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Files.App/ServicesImplementation/Settings/PreferencesSettingsService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ public bool OpenFoldersWithOneClick
set => Set(value);
}

public bool ColumnLayoutOpenFoldersWithOneClick
{
get => Get(true);
set => Set(value);
}

public bool SearchUnindexedItems
{
get => Get(false);
Expand Down Expand Up @@ -147,6 +153,7 @@ protected override void RaiseOnSettingChangedEvent(object sender, SettingChanged
case nameof(ShowDotFiles):
case nameof(OpenFilesWithOneClick):
case nameof(OpenFoldersWithOneClick):
case nameof(ColumnLayoutOpenFoldersWithOneClick):
case nameof(SearchUnindexedItems):
case nameof(ForceLayoutPreferencesOnAllDirectories):
case nameof(ShowFolderSize):
Expand All @@ -172,6 +179,7 @@ public void ReportToAppCenter()
Analytics.TrackEvent($"{nameof(ShowDotFiles)}, {ShowDotFiles}");
Analytics.TrackEvent($"{nameof(OpenFilesWithOneClick)}, {OpenFilesWithOneClick}");
Analytics.TrackEvent($"{nameof(OpenFoldersWithOneClick)}, {OpenFoldersWithOneClick}");
Analytics.TrackEvent($"{nameof(ColumnLayoutOpenFoldersWithOneClick)}, {ColumnLayoutOpenFoldersWithOneClick}");
Analytics.TrackEvent($"{nameof(SearchUnindexedItems)}, {SearchUnindexedItems}");
Analytics.TrackEvent($"{nameof(ForceLayoutPreferencesOnAllDirectories)}, {ForceLayoutPreferencesOnAllDirectories}");
Analytics.TrackEvent($"{nameof(ShowFolderSize)}, {ShowFolderSize}");
Expand Down
6 changes: 6 additions & 0 deletions src/Files.App/Strings/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2825,4 +2825,10 @@ We use App Center to track which settings are being used, find bugs, and fix cra
<data name="Lockscreen" xml:space="preserve">
<value>Lockscreen</value>
</data>
<data name="OpenFolderWithOneClickColumnsLayout" xml:space="preserve">
<value>Open folders with a single click in the Columns Layout</value>
</data>
<data name="BehaviorForOpeningFilesAndFolders" xml:space="preserve">
<value>Behavior for opening files and folders</value>
</data>
</root>
17 changes: 13 additions & 4 deletions src/Files.App/ViewModels/SettingsViewModels/PreferencesViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using Files.Shared.Services.DateTimeFormatter;
using Files.App.Controllers;
using Files.App.DataModels;
using Files.App.Filesystem;
using Files.App.Helpers;
using Files.App.Extensions;
using CommunityToolkit.WinUI;
Expand All @@ -19,12 +18,9 @@
using System.Threading.Tasks;
using System.Windows.Input;
using Windows.ApplicationModel;
using Windows.Foundation.Collections;
using Windows.Storage;
using Windows.Storage.AccessCache;
using Windows.Storage.Pickers;
using Windows.System;
using Microsoft.UI.Xaml.Controls;
using DispatcherQueue = Microsoft.UI.Dispatching.DispatcherQueue;
using static Files.App.Helpers.MenuFlyoutHelper;
using Files.App.Shell;
Expand Down Expand Up @@ -619,6 +615,19 @@ public bool OpenFoldersWithOneClick
}
}

public bool ColumnLayoutOpenFoldersWithOneClick
{
get => UserSettingsService.PreferencesSettingsService.ColumnLayoutOpenFoldersWithOneClick;
set
{
if (value != UserSettingsService.PreferencesSettingsService.ColumnLayoutOpenFoldersWithOneClick)
{
UserSettingsService.PreferencesSettingsService.ColumnLayoutOpenFoldersWithOneClick = value;
OnPropertyChanged();
}
}
}

public bool ListAndSortDirectoriesAlongsideFiles
{
get => UserSettingsService.LayoutSettingsService.DefaultSortDirectoriesAlongsideFiles;
Expand Down
Loading