Skip to content

Feature: Added option to double click to open folders in column layout #9932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Details of Changes

  • I splitted the 'if' that checks if the item should be opened so that even if SelectedItem is a folder, the Up_Click() method is not called

Validation

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Sep 6, 2022

We need a dedicated setting for column view. The default app behavior should be double click for the detail and grid layouts, and single click for columns.

This new setting should only apply when clicking folders in the column layout, other items will continue to follow the existing setting.

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Sep 6, 2022
@yaira2
Copy link
Member

yaira2 commented Sep 6, 2022

@ferrariofilippo thank you! I pushed a couple of changes to improve the code readability.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Sep 6, 2022
@yaira2 yaira2 changed the title Feature: Support double click in the column layout #9704 Feature: Added option to double click to open folders in column layou Sep 6, 2022
@yaira2 yaira2 changed the title Feature: Added option to double click to open folders in column layou Feature: Added option to double click to open folders in column layoutt Sep 6, 2022
@yaira2 yaira2 changed the title Feature: Added option to double click to open folders in column layoutt Feature: Added option to double click to open folders in column layout Sep 6, 2022
@yaira2 yaira2 merged commit 0905670 into files-community:main Sep 6, 2022
@ferrariofilippo ferrariofilippo deleted the Feature_DoubleClick_ColumnLayout_#9704 branch September 12, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support double click in addition to single click in the column layout
2 participants