Skip to content

Feature: Added option to restore all items in recycle bin #9795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes

  • Added Restore Recycle Bin action in contextual menu of Recycle Bin when no object is selected.
  • Added Restore Recycle Bin action in Inner Navigation Toolbar.
  • Added localization linked to the new action.

Validation
How did you test these changes?

  • Built and ran the app

Screenshots

9561_Proof

@yaira2
Copy link
Member

yaira2 commented Aug 22, 2022

Added Restore Recycle Bin action in Inner Navigation Toolbar.

Great idea! Perhaps it can be simplified to say "restore" when multiple items are selected? I'd add a separate button when no items are selected that says "Restore all items".

@yaira2 yaira2 changed the title 9561 no restore action in recycle bin Feature: Added option to restore all items in recycle bin Aug 22, 2022
@QuaintMako
Copy link
Contributor Author

I probably won't be able to attend to the PR for a few more days. If someone wants to take it up, feel free.
Will try to do it on the week-end.

@QuaintMako
Copy link
Contributor Author

Added Restore Recycle Bin action in Inner Navigation Toolbar.

Great idea! Perhaps it can be simplified to say "restore" when multiple items are selected? I'd add a separate button when no items are selected that says "Restore all items".

Working on it.

@yaira2
Copy link
Member

yaira2 commented Aug 29, 2022

Should I implement two similar buttons for the emptying? One to empty all, one to empty the selection.

That's correct, the first option should only be visible when nothing is selected.

@yaira2
Copy link
Member

yaira2 commented Aug 29, 2022

@QuaintMako can you resolve the merge conflict?

@yaira2
Copy link
Member

yaira2 commented Aug 29, 2022

Happy for you to leave it open as a draft 👍

@QuaintMako
Copy link
Contributor Author

Learning the existence of that draft thingy, sweet! Converting it into one.

@QuaintMako QuaintMako marked this pull request as draft August 29, 2022 22:39
@QuaintMako
Copy link
Contributor Author

Closing the PR to redo it entirely.
Some of the part used by the made work are using parts that have been deeply changed by new contributions. Will be easier and cleaner to start from an updated state.

@QuaintMako QuaintMako closed this Sep 8, 2022
@QuaintMako QuaintMako deleted the 9561_NoRestoreActionInRecycleBin branch September 8, 2022 07:10
@files-community files-community deleted a comment from QuaintMako Sep 14, 2023
@files-community files-community deleted a comment from QuaintMako Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Restore option is missing from recycle bin
2 participants