-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix: Fixed an issue where the restore option was missing from recycle bin #10004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed an issue where the restore option was missing from recycle bin #10004
Conversation
…cycle bin toolbar.
The option to "Empty Selection" is a bit redundant as there is already the delete option. |
It is indeed, but it's something that was asked for during the previous PR for that issue : #9795 (comment). I can remove it if it's no longer asked for. |
My apologies, I wasn't accounting for the existing delete option at the time. |
Alright, so nuking it? |
Yeah |
Got it. Should the "Empty Recycle Bin" button disappear from the toolbar when selecting items? Leaving just the "Restore Selection" one. |
I think that should always be visible |
Somehow the last merge done using Github interface messed up the project generation. EDIT: Coming from the merge on the localization files apparently. Will fix it during the day most likely. |
That should do it. The "Empty Selection" action has been fully removed and the merge issues have been fixed. |
This might work for the restore icon |
Changed the restore icon, the one proposed it way better. |
Resolved / Related Issues
What has been done
from src/Files.App/Interacts/BaseLayoutCommandImplementationModel.cs
tosrc/Files.App/Interacts/BaseLayoutCommandImplementationModel.cs
Validation
How did you test these changes?
Screenshots (optional)