Skip to content

Feature: Display uncompressed size when viewing properties for archives #9782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2022
Merged

Feature: Display uncompressed size when viewing properties for archives #9782

merged 4 commits into from
Aug 21, 2022

Conversation

btomblinson
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes

  • In Properties General: Added new display
  • In Resources.resw (en-US): Added new item for uncompressed prompt
  • In ZipStorageFolder: Add function using SevenZipSharp to extract the zip by file path, and then loop through the extracted data summing the size

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes and compared the result to what the file size is if you extract

Screenshots (optional)
image
image

@btomblinson btomblinson changed the title 8990 Feature - Add uncompressed size for viewing zip properties #8990 Aug 21, 2022
yaira2
yaira2 reviewed Aug 21, 2022
View reviewed changes
@yaira2 yaira2 self-requested a review August 21, 2022 12:45
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Aug 21, 2022
yaira2
yaira2 reviewed Aug 21, 2022
View reviewed changes
yaira2
yaira2 reviewed Aug 21, 2022
View reviewed changes
yaira2
yaira2 reviewed Aug 21, 2022
View reviewed changes
@yaira2 yaira2 changed the title Feature - Add uncompressed size for viewing zip properties #8990 Feature: Add uncompressed size when viewing properties for archives Aug 21, 2022
@yaira2 yaira2 changed the title Feature: Add uncompressed size when viewing properties for archives Feature: Display uncompressed size when viewing properties for archives Aug 21, 2022
@gave92
Copy link
Member

gave92 commented Aug 21, 2022

Pushed a couple of changes:

  • Applied code review comments
  • Removed computation of uncompressed size from Win32StorageEnumerator. Since the unc. size is only shown in Properties we can avoid slowing down the file list loading

@gave92 gave92 added needs - code review and removed changes requested Changes are needed for this pull request labels Aug 21, 2022
@gave92 gave92 requested a review from yaira2 August 21, 2022 22:04
yaira2
yaira2 approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@btomblinson @gave92 thank you for working on this!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 21, 2022
@yaira2 yaira2 merged commit f6db0c6 into files-community:main Aug 21, 2022
@gave92 gave92 mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add uncompressed size for viewing zip properties
3 participants
@btomblinson @gave92 @yaira2