Skip to content

Feature: Added arm64 version 7z.dll #9763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Feature: Added arm64 version 7z.dll #9763

wants to merge 3 commits into from

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 19, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.
Added 7zip dll for arm64

Validation
How did you test these changes?

  • Requires further validation

@gave92
Copy link
Member

gave92 commented Aug 19, 2022

I also need to add some logic to load the arm version.

@yaira2
Copy link
Member Author

yaira2 commented Aug 19, 2022

I was looking in the code but I didn't see where the dlls were being used 😂

@gave92
Copy link
Member

gave92 commented Aug 19, 2022

Ehe, I know. Code for it is in the sevenzipsharp nuget package.

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 20, 2022
gave92
gave92 previously approved these changes Aug 20, 2022
@gave92
Copy link
Member

gave92 commented Aug 20, 2022

Not sure it works. Perhaps you can give the guy the package from azure to test before merging.

Relevant commit: files-community/SevenZipSharp@a921e76

@gave92
Copy link
Member

gave92 commented Aug 21, 2022

Confirmed working then?

@yaira2
Copy link
Member Author

yaira2 commented Aug 21, 2022

Confirmed working then?

Not yet...

gave92
gave92 previously approved these changes Aug 21, 2022
@yaira2
Copy link
Member Author

yaira2 commented Aug 22, 2022

@gave92 seems like I included the wrong dll file, do you know where I can find the correct file?
https://appcenter.ms/orgs/FilesApp/apps/Files/crashes/errors/925843331u/overview

@gave92
Copy link
Member

gave92 commented Aug 22, 2022

That crash is not related to the 7z dll. It's a bug I've introduced in #9782. Remember me to fix it xD

@yaira2
Copy link
Member Author

yaira2 commented Aug 22, 2022

That crash is not related to the 7z dll. It's a bug I've introduced in #9782. Remember me to fix it xD

Can this prevent users from opening 7z files on ARM64?

@gave92
Copy link
Member

gave92 commented Aug 22, 2022

Nope, that should only happen if you open file properties window for an archive

@gave92 gave92 removed the ready to merge Pull requests that are approved and ready to merge label Aug 27, 2022
@yaira2
Copy link
Member Author

yaira2 commented Sep 1, 2022

Closing this for now since we don't have a working Arm64 build

@yaira2 yaira2 closed this Sep 1, 2022
@yaira2 yaira2 deleted the ya/7zipArm64 branch October 30, 2022 03:55
@yaira2
Copy link
Member Author

yaira2 commented Jun 25, 2024

I also need to add some logic to load the arm version.

@gave92 was this logic added in the end?

@gave92
Copy link
Member

gave92 commented Jun 25, 2024

I think so:

"return IsRunningOnArm ? "7zArm64.dll" : Environment.Is64BitProcess ? "7z64.dll" : "7z.dll";"

@yaira2
Copy link
Member Author

yaira2 commented Jun 25, 2024

Thank you for confirming! Where did you get the dll files for the other architectures?

I found the files on the 7zip site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants