-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Added arm64 version 7z.dll #9763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I also need to add some logic to load the arm version. |
I was looking in the code but I didn't see where the dlls were being used 😂 |
Ehe, I know. Code for it is in the sevenzipsharp nuget package. |
Not sure it works. Perhaps you can give the guy the package from azure to test before merging. Relevant commit: files-community/SevenZipSharp@a921e76 |
Confirmed working then? |
Not yet... |
@gave92 seems like I included the wrong dll file, do you know where I can find the correct file? |
That crash is not related to the 7z dll. It's a bug I've introduced in #9782. Remember me to fix it xD |
Can this prevent users from opening 7z files on ARM64? |
Nope, that should only happen if you open file properties window for an archive |
Closing this for now since we don't have a working Arm64 build |
@gave92 was this logic added in the end? |
I think so:
|
I found the files on the 7zip site |
Resolved / Related Issues
Items resolved / related issues by this PR.
Added 7zip dll for arm64
Validation
How did you test these changes?