Skip to content

Revert "After pasting, focus all pasted files/folders instead of just one" #9304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 31, 2022

Reverts #9299

@yaira2
Copy link
Member Author

yaira2 commented May 31, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2
Copy link
Member Author

yaira2 commented May 31, 2022

FYI @IgorKordiukiewicz
I think this it's best to revert this change until the fix is ready

@IgorKordiukiewicz
Copy link
Contributor

Yeah, I tried to fix it but since the files changes are processed separately, I don't think there is a way to reset itemsAdded properly.

@jiejasonliu
Copy link
Contributor

jiejasonliu commented Jun 1, 2022

I don't think there is a way to reset itemsAdded properly.

Yeah, unfortunately that's exactly why I never implemented this when I was working on selecting singular files.

If interested, there's the potential solution of keeping track of the items that are pasted before it's flattened into separate requests, then when those items are a subset of itemsAdded, you can select the items and reset the list.

This should also fix a different bug where pastes from other Files windows or File Explorer will cause items to be selected.

@yaira2 yaira2 merged commit bf979b8 into main Jun 2, 2022
@yaira2 yaira2 deleted the revert-9299-focus-items-after-paste branch June 2, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants