After pasting, focus all pasted files/folders instead of just one

[IgorKordiukiewicz]

Resolved / Related Issues
Fixes #8333

Details of Changes

Validation
How did you test these changes?

• Built and ran the app

Before:

paste_selection_old.mp4

After:

paste_selection_new.mp4

[yaira2]

@IgorKordiukiewicz thank you for the pr, can you check the validation check box in the PR description?

[IgorKordiukiewicz]

@IgorKordiukiewicz thank you for the pr, can you check the validation check box in the PR description?

Updated

[puppetsw]

LGTM

[jiejasonliu]

I believe this introduces a bug where future pastes will focus on the previous ones since we never reset the itemsAdded list.
This may be a little tricky to fix since we flatten out multi-paste operations into sequential ones.

[IgorKordiukiewicz]

Well, it kind of gets reset every time the ProcessOperationQueue is called sine its created there, so I don't think this will be a problem and I didn't notice this bug happening.

[puppetsw]

I believe this introduces a bug where future pastes will focus on the previous ones since we never reset the itemsAdded list. This may be a little tricky to fix since we flatten out multi-paste operations into sequential ones.

I didn't notice this bug happening during testing, are you able to provide steps?

[jiejasonliu]

Well, it kind of gets reset every time the ProcessOperationQueue is called sine its created there, so I don't think this will be a problem and I didn't notice this bug happening.

It's correct that it's reset whenever ProcessOperationQueue is called; however the lifetime of this method is one to the directory, meaning it's only called once per directory change.

I didn't notice this bug happening during testing, are you able to provide steps?

Sure, a way to reproduce is to copy and paste some files, and then in the same directory, copy and paste some other files.
You'll see the previous paste will be included as well. I've prepared a gif that demonstrates this issue.

step 1: copy-paste 5 files
step 2: copy-paste just 4.txt (i do this twice)

[puppetsw]

Sure, a way to reproduce is to copy and paste some files, and then in the same directory, copy and paste some other files. You'll see the previous paste will be included as well. I've prepared a gif that demonstrates this issue.

Ah thank you. I was misunderstanding the method to replicate.