-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[Post v2.3] Improves pinned RecycleBin #9207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you navigate to recycle bin from the address bar? |
With this PR yes, by typing "shell:recyclebinfolder" (it has always been possible but one of my PRs recently broke this). |
Agreed, I think that should be included with this PR as it's already changing the way it works. |
This PR doesn't change things. The option in settings still exists here. |
Resolved / Related Issues
The favorite RecycleBin is particular. We can't move it. In the code, it is handled separately.
The context menu of the RecycleBin page does not offer an entry for Pin/Unpin.
Details of Changes
The RecycleBin favorite becomes a favorite like any other, stored like any other. It can be moved and retains its specific menu entries.
The setting to display it is retained. He has priority at the start of the session to add/remove the favorite if necessary. This makes it possible not to break the user's current preferences.
The context menu of the RecycleBin page offers an entry for Pin/Unpin.
Validation
How did you test these changes?