Skip to content

[Post v2.3] Improves pinned RecycleBin #9207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2022

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented May 17, 2022

Resolved / Related Issues
The favorite RecycleBin is particular. We can't move it. In the code, it is handled separately.
The context menu of the RecycleBin page does not offer an entry for Pin/Unpin.

Details of Changes
The RecycleBin favorite becomes a favorite like any other, stored like any other. It can be moved and retains its specific menu entries.

The setting to display it is retained. He has priority at the start of the session to add/remove the favorite if necessary. This makes it possible not to break the user's current preferences.

The context menu of the RecycleBin page offers an entry for Pin/Unpin.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 changed the title Improves pinned RecycleBin [Post v2.3] Improves pinned RecycleBin May 17, 2022
@gave92 gave92 self-requested a review June 4, 2022 10:36
gave92
gave92 previously approved these changes Jun 4, 2022
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 4, 2022
@gave92 gave92 self-requested a review June 4, 2022 11:16
@yaira2
Copy link
Member

yaira2 commented Jun 8, 2022

Can you navigate to recycle bin from the address bar?

@yaira2 yaira2 self-requested a review June 8, 2022 14:10
@yaira2 yaira2 added needs - code review and removed ready to merge Pull requests that are approved and ready to merge labels Jun 8, 2022
@gave92
Copy link
Member

gave92 commented Jun 8, 2022

With this PR yes, by typing "shell:recyclebinfolder" (it has always been possible but one of my PRs recently broke this).
This is not really obvious, if the plan is to remove the option to pin recycle bin on sidebar from settings we need to find an easier way to navigate to bin.

@yaira2
Copy link
Member

yaira2 commented Jun 8, 2022

Agreed, I think that should be included with this PR as it's already changing the way it works.

@gave92
Copy link
Member

gave92 commented Jun 8, 2022

This PR doesn't change things. The option in settings still exists here.
I'd suggest to merge it like this. Removing the setting can be done in a different PR, once we have a clear idea about how to make it easy to navigate to bin.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 9, 2022
@yaira2 yaira2 merged commit 7c348ff into files-community:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for pinning recycle bin to favorites Add support for reordering recycle bin item
3 participants