-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add support for Synology Drive Client #9188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Files.Uwp/Filesystem/Cloud/Providers/SynologyDriveCloudProvider.cs
Outdated
Show resolved
Hide resolved
Hi, I don't have the possibility to test this, but out of curiosity could you check if in registry under |
There is one, but just for showing the name of the server, nothing about the folders: Feel free to ask any other thing you think of. |
Thanks, I'm asking because that's where Cloud drives that integrate with Explorer register themselves (and indeed you've found Synology). This is what we do to detect a few cloud drives (OneDrive, Box, iCloudDrive, Dropbox, Nextcloud, MEGA, Amazon Drive). |
Now it should work with any database. Also added server name to the folder name
Ok, now it should work in each database. I got the connection id for other database, and in that database there is connection_type for knowing if a connection is for sync or for backup. I also added the host name to the drive folder as Windows does. BTW, Files shows all synced folders while Windows only shows the last one: |
@BanCrash made a couple of small changes (replaced SynologyDriveConnection with a Tuple, skip invalid entries instead of returning no results). Hopefully I haven't broken anything. If you agree with the changes, this looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you! Just tested and still working as expected.
Resolved / Related Issues
Items resolved / related issues by this PR.
Details of Changes
NOTE: I never used Synology Drive Client for sync before, just for backups, so while in my tests it's working I can't assure it will work for all scenarios since I had to figure out how the information is stored on the database, but maybe I figured it out wrong and it needs some readjustments. When this is added I would like to receive feedback from the users to check if it's working for them too.
Validation
Screenshots (optional)
