Skip to content

Formatted Storage (again) #8963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 12, 2022
Merged

Formatted Storage (again) #8963

merged 9 commits into from
Jun 12, 2022

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Apr 20, 2022

We continue the formatting of Storage. These files contain undesirable ViewModels and App dependencies. These dependencies will be removed in a future pr.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2 yaira2 requested a review from d2dyno1 April 25, 2022 14:20
@cinqmilleans
Copy link
Contributor Author

Fix merge #8952.

@cinqmilleans
Copy link
Contributor Author

@yaichenbaum @gave92 I allow myself to ask if a review of this PR is in progress. I need this to progress with ListedItem refactoring.

@yaira2 yaira2 removed the request for review from d2dyno1 June 10, 2022 14:10
@yaira2
Copy link
Member

yaira2 commented Jun 10, 2022

We're still waiting for verification that the branch was tested and ran.

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 11, 2022
@yaira2 yaira2 merged commit c65cdc4 into files-community:main Jun 12, 2022
@cinqmilleans cinqmilleans deleted the Storage branch December 23, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants