Skip to content

Add support for browsing shell folders #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 5, 2022
Merged

Add support for browsing shell folders #9089

merged 20 commits into from
May 5, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented May 4, 2022 •
edited
Loading

Details of Changes
Add details of changes here.

  • Allows to browse shell folders in Files: e.g Control Panel ("shell:controlpanelfolder"), All apps folder ("shell:appsfolder"), etc.

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 requested review from BanCrash and removed request for BanCrash May 4, 2022 20:26
@gave92 gave92 marked this pull request as draft May 4, 2022 20:41
@gave92 gave92 marked this pull request as ready for review May 4, 2022 20:52
@gave92 gave92 marked this pull request as draft May 4, 2022 20:53
@gave92 gave92 marked this pull request as ready for review May 4, 2022 21:23
@gave92
Copy link
Member Author

gave92 commented May 5, 2022 •
edited
Loading

TODOs in next PR:

  • Show folder names instead of wierd strings in the navbar and tab title

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 5, 2022
@yaira2 yaira2 merged commit 4c8b9da into main May 5, 2022
@yaira2 yaira2 deleted the shell_browse branch May 5, 2022 19:44
@yaira2
Copy link
Member

yaira2 commented May 5, 2022

@gave92 thank you!

cinqmilleans added a commit to cinqmilleans/Files that referenced this pull request May 8, 2022
@cinqmilleans
fix merge files-community#9089
0d666a4
@gave92 gave92 mentioned this pull request May 12, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gave92 @yaira2