Skip to content

Fixes an issue causing file tags list to be serialized wrong #7017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2021
Merged

Fixes an issue causing file tags list to be serialized wrong #7017

merged 4 commits into from
Nov 22, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Nov 22, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added FileTag class to rd.xml. Without it file tags do not get serialized correctly in Release mode
  • Fixed an issue where going to Preferences before sidebar is loaded crashed the app

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title Fix null settings Fixes an issue causing file tags list to be serialized wrong Nov 22, 2021
yaira2
yaira2 approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 22, 2021
@yaira2 yaira2 merged commit 372892e into files-community:main Nov 22, 2021
@yaira2 yaira2 mentioned this pull request Nov 22, 2021
Closed
@gave92 gave92 deleted the fix_null_settings branch November 22, 2021 07:26
@gave92 gave92 mentioned this pull request Nov 22, 2021
Closed
@gave92 gave92 mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files crash while opening any folder
2 participants
@gave92 @yaira2