Skip to content

Fix copying shortcuts, small changes to ftp #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2021
Merged

Fix copying shortcuts, small changes to ftp #6703

merged 7 commits into from
Nov 7, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Nov 4, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Fixes an issue where files are not copied if any is a shortcut
  • Fixes an issue where folder shortcuts don't open in ColumnView

Details of Changes
Add details of changes here.

  • Fixed an issue where files are not copied if any is a shortcut
  • Fixed an issue where folder shortcuts did not open in ColumnView
  • Process commands in parallel in the fulltrust process
  • Delay loading the "new item" context menu after the rest of the stuff is loaded (and stop using "Task.Run().Result"). Rationale: after Move registry usage to FTP #6657 the "new item" menu is fetched from FTP but it does not make sense to load it before the sidebar etc.)

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 closed this Nov 4, 2021
@gave92 gave92 reopened this Nov 4, 2021
@gave92 gave92 marked this pull request as draft November 4, 2021 17:36
@gave92 gave92 changed the title Improve sidebar loading time Fix copying shortcuts, small changes to ftp Nov 4, 2021
@gave92 gave92 marked this pull request as ready for review November 4, 2021 18:51
@yaira2 yaira2 requested a review from d2dyno1 November 4, 2021 18:54
d2dyno1
d2dyno1 reviewed Nov 4, 2021
View reviewed changes
@yaira2 yaira2 requested a review from d2dyno1 November 5, 2021 14:53
d2dyno1
d2dyno1 reviewed Nov 5, 2021
View reviewed changes
d2dyno1
d2dyno1 approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d2dyno1 d2dyno1 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 5, 2021
@yaira2 yaira2 merged commit 223b7eb into files-community:main Nov 7, 2021
@gave92 gave92 deleted the fix_startup branch November 7, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2dyno1 d2dyno1 d2dyno1 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gave92 @d2dyno1 @yaira2