Skip to content

Move registry usage to FTP #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 31, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 30, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

As it was proven that references to Microsoft.Win32.Registry in UWP causes the app to hang on start (Store version), this PR moves functionalities that use Registry to fulltrust process (mainly "new" context menu parsing, cloud drives detection)

Details of Changes
Add details of changes here.

  • Moved registry reading to FTP
  • Removed CustomOpenDialog32.dll, CustomOpenDialog64.dll from repo and added them to .gitignore
  • Fixed an issue where the fulltrust process keeps running when the main app crashes (not that it ever happens)

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 mentioned this pull request Oct 30, 2021
@gave92 gave92 marked this pull request as ready for review October 30, 2021 16:58
@yaira2
Copy link
Member

yaira2 commented Oct 31, 2021

Fixed an issue where the fulltrust process keeps running when the main app crashes (not that it ever happens)

@gave92 of course it never happens 😆

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 31, 2021
@yaira2 yaira2 merged commit d35cb26 into files-community:main Oct 31, 2021
@gave92 gave92 deleted the ftp_open_in_crash_readd_registry branch October 31, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants