Skip to content

Fix thumbnails getting squished into squares #6434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 11, 2021

Details of Changes
Add details of changes here.

As the docs for DecodePixelWidth say: "if DecodePixelHeight is also set, the aspect ratio of the bitmap is ignored. If DecodePixelHeight is not set, the aspect ratio remains the same."

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title Fix thumbnails gettin squished into squares Fix thumbnails getting squished into squares Oct 11, 2021
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 11, 2021
@yaira2 yaira2 merged commit 1a688f6 into files-community:main Oct 11, 2021
@gave92 gave92 deleted the square_img branch October 11, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants