-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Don't convert primary thumbnail to byte array #6104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yaichenbaum and I did some testing and it's a mixed bag: 1.) This change didn't yield a very large improvement in thumbnail load times. In fact, they were mostly comparable across the two versions I think we should go ahead with this change after I fix the Properties dialog thumbnails, but I'll let this sit for some more input |
@duke7553 I think it makes sense to continue with this and hopefully we can include it in one of the next preview builds. For the meantime, do you think you can add back the wireframe placeholder icon until we get a change to come up with a proper alternative? |
Is this still relevant? |
This comment has been minimized.
This comment has been minimized.
Ok! I was just checking on if any work is still being made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Resolved / Related Issues
Details of Changes
Validation
How did you test these changes?
Tested the changes for accessibilityScreenshots (optional)
N/A