Skip to content

feat: Don't convert primary thumbnail to byte array #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2021
Merged

feat: Don't convert primary thumbnail to byte array #6104

merged 5 commits into from
Oct 11, 2021

Conversation

lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Sep 11, 2021

Resolved / Related Issues

Details of Changes

  • Removes unneeded reliance on thumbnail byte array for remaining app surfaces
  • Switches away from glyphs as icons of items with unloaded extended properties

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
N/A

@lukeblevins
Copy link
Contributor Author

@yaichenbaum and I did some testing and it's a mixed bag:

1.) This change didn't yield a very large improvement in thumbnail load times. In fact, they were mostly comparable across the two versions
2.) It did, however, reduce memory usage by 35% during the particularly synthetic scenario where one loads a large directory and scrolls every item into the viewport (That amounted to 200MB for 4620 items in System32)
3.) CPU usage was lower (-5%), but not consistently less enough to be significant

I think we should go ahead with this change after I fix the Properties dialog thumbnails, but I'll let this sit for some more input

@yaira2
Copy link
Member

yaira2 commented Sep 12, 2021

@duke7553 I think it makes sense to continue with this and hopefully we can include it in one of the next preview builds. For the meantime, do you think you can add back the wireframe placeholder icon until we get a change to come up with a proper alternative?

@d2dyno1
Copy link
Member

d2dyno1 commented Oct 3, 2021

Is this still relevant?

@lukeblevins

This comment has been minimized.

@d2dyno1
Copy link
Member

d2dyno1 commented Oct 3, 2021

Ok! I was just checking on if any work is still being made.

@lukeblevins lukeblevins marked this pull request as ready for review October 10, 2021 20:44
@lukeblevins lukeblevins requested a review from yaira2 October 10, 2021 20:45
@lukeblevins lukeblevins requested a review from d2dyno1 October 10, 2021 20:57
@yaira2 yaira2 requested a review from gave92 October 10, 2021 21:47
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 11, 2021
@yaira2 yaira2 merged commit 8c4b871 into main Oct 11, 2021
@yaira2 yaira2 deleted the thumbnails branch October 11, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: Investigate the fetching of unneeded byte array per storage item
3 participants