Skip to content

Fix wrong file names in zip files when they contain Chinese characters #6317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 10, 2021
Merged

Fix wrong file names in zip files when they contain Chinese characters #6317

merged 7 commits into from
Oct 10, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 6, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added auto detection of the encoding of file names inside zip files

Validation
How did you test these changes?

  • Built and ran the app
  • Tested browsing and extraction of the attached zip files

ZIP1_WIN1252.zip
ZIP2_GB2312.zip
ZIP3_UTF8.zip

@yaira2 yaira2 requested a review from BanCrash October 6, 2021 00:21
gave92
gave92 commented Oct 6, 2021
View reviewed changes
d2dyno1
d2dyno1 previously requested changes Oct 9, 2021
View reviewed changes
@gave92 gave92 requested a review from d2dyno1 October 9, 2021 19:26
BanCrash
BanCrash approved these changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 10, 2021
@yaira2 yaira2 merged commit 309930a into files-community:main Oct 10, 2021
@yaira2 yaira2 mentioned this pull request Oct 10, 2021
Closed
@gave92 gave92 deleted the issue_6282 branch October 10, 2021 14:23
@BanCrash BanCrash mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BanCrash BanCrash BanCrash approved these changes

@d2dyno1 d2dyno1 Awaiting requested review from d2dyno1

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When open a zip file, if have chinese contents, file's name gonna in a mess
4 participants
@gave92 @BanCrash @d2dyno1 @yaira2