Skip to content

Show file operation progress on Taskbar & continue operations when minimized #6273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 3, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Show ongoing progress for file operations on taskbar
  • Do not stop filesystem operations when Files window is minimized
  • Fixes an issue where the progress ring would show on the toolbar after canceling an operation
  • Fixes an issue where a tab would show the loading indicator indefinitely on app start

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title Taskbar progress Show file operation progress on Taskbar & continue operations when minimized Oct 3, 2021
@yaira2 yaira2 requested a review from d2dyno1 October 3, 2021 23:02
@gave92 gave92 requested a review from d2dyno1 October 5, 2021 17:04
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 5, 2021
@yaira2 yaira2 merged commit a7c76f0 into files-community:main Oct 5, 2021
@gave92 gave92 deleted the taskbar_progress branch October 5, 2021 17:29
gave92 added a commit to gave92/files-uwp that referenced this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show ongoing tasks indicator on the taskbar The tab loading indicator keeps loading infinitely
3 participants