Sort #256
Merged
Sort #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files and folders can now be sorted by clicking on the column headers or by using the right-click context menu. The sorting order mimics Windows Explorer, by grouping the folders and files separately first, then applying the relevant sort on the specified column, then finally sorting by name. Also: - Improves right-click context menu action grouping - Removes RowIndex from ListedItem.cs as it is not a reliable way to access items (indices change) after sorting is implemented - Refactors code to work around the absence of RowIndex - Other minor code refactoring
Add sorting function to files list
Also: - Adds SortOption enum to represent current file attribute to sort by - Moves sorting logic to ItemViewModel from GenericFileBrowser. This allows sorting options to persist through folder navigation Issues: - Navigating to another folder currently sorts its files only after all of them are loaded.
Add sorting to PhotoAlbum
This commit completes the implementation of sorting in Files by adding a "Sort by" button to the ribbon. Other changes: - Moves all sorting-related properties (e.g. IsSortedByName) to ItemViewModel from GenericFileBrowser and PhotoAlbum - Refactors all instances of NotifyPropertyChanged to use the CallerMemberName attribute - Removes some unused namespace references
Add sort button to app ribbon
lukeblevins
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.