-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add sorting function to files list #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Files and folders can now be sorted by clicking on the column headers or by using the right-click context menu. The sorting order mimics Windows Explorer, by grouping the folders and files separately first, then applying the relevant sort on the specified column, then finally sorting by name. Also: - Improves right-click context menu action grouping - Removes RowIndex from ListedItem.cs as it is not a reliable way to access items (indices change) after sorting is implemented - Refactors code to work around the absence of RowIndex - Other minor code refactoring
Do these changes apply to the photo view as well? |
No, only on the default list view. |
Ok, I tested this and it works as expected, were you planning on doing it for photo view as well? |
How does it work on photo view? Is it just via the right click menu, since there are no column headers? I haven't thought about doing it for the photo view as I don't usually use the photo view in Windows Explorer haha. But I guess I could get around to doing it some time soon. |
@jeffsieu Great work! |
My only concern would be if this breaks any functions that perform an action on a specific DataGrid index. This will require a bit of testing, still great to have regardless. Edit: I now see you mentioned this already. |
@yaira2 @jeffsieu Looks great. After testing, I found several issues which we will need to address before I merge this branch to master: |
@duke7553 I've added sort by to PhotoAlbum and fixed 1). All that's left is making the sort dropdown in the ribbon. As to 3), which part of sorting by "Date modified" is inaccurate? |
@duke7553 Can you explain what you meant by "Date modified" being inaccurate? |
Files and folders can now be sorted by clicking on
the column headers or by using the right-click context
menu. The sorting order mimics Windows Explorer,
by grouping the folders and files separately first, then
applying the relevant sort on the specified column,
then finally sorting by name.
Also:
RowIndex
fromListedItem.cs
as it is not a reliable way to access items (indices change) after sorting is implementedRowIndex
Screenshots
Related Issues
Closes #178
Possibly related: #20