Skip to content

Fix: Fixed issue where Open with and Send to submenus didn't appear properly in Widgets #14879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Mar 2, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Widgets doesn't replace Open with and Send to menu #14878

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu changed the title Fix: Fix Open with and Send to Fix: Fixed issue where Open with and Send to submenus didn't appear properly in Widgets Mar 2, 2024
@hishitetsu
Copy link
Member Author

This breaks icon position. This is definitely a regression of Windows App SDK 1.5, so it may want to revert to 1.4.

スクリーンショット 2024-03-02 144923

@yaira2
Copy link
Member

yaira2 commented Mar 3, 2024

This breaks icon position. This is definitely a regression of Windows App SDK 1.5, so it may want to revert to 1.4.

We should see if can fix by updating the style, otherwise we can open a report and revert to 1.4.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 3, 2024
@yaira2 yaira2 merged commit 93566ce into files-community:main Mar 3, 2024
@hishitetsu hishitetsu deleted the FixWidgetMenu branch March 4, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Widgets doesn't replace Open with and Send to menu
2 participants