Skip to content

Feature: Added support for copying files with ADS to FAT32 #12039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2023
Merged

Feature: Added support for copying files with ADS to FAT32 #12039

merged 1 commit into from
Apr 16, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Apr 10, 2023 •
edited
Loading

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Copy or move a file with a tag to a FAT32 formatted usb drive

Screenshots (optional)
Screenshot 2023-04-10 181149

@yaira2 yaira2 changed the title Allow to copy files with ADS to FAT32 Feature: Added support for copying files with ADS to FAT32 Apr 10, 2023
@Josh65-2201
Copy link
Member

Would this also fix #9423?

yaira2
yaira2 approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 1e4d924 into files-community:main Apr 16, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 16, 2023
yaira2
yaira2 reviewed Apr 16, 2023
View reviewed changes
src/Files.App/Filesystem/FilesystemOperations/ShellFilesystemOperations.cs
{
var failedSources = moveResult.Items.Where(x => CopyEngineResult.Convert(x.HResult) == FileSystemStatusCode.PropertyLoss);
var filePath = failedSources.Select(x => x.Source);
switch (await GetFileListDialog(filePath, "FilePropertiesCannotBeMoved".GetLocalizedResource(), "MoveFileWithoutProperties".GetLocalizedResource(), "OK".GetLocalizedResource(), "Cancel".GetLocalizedResource()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the text to "Continue" or "Yes"?

@gave92 gave92 deleted the issue_11570 branch April 16, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
3 participants
@gave92 @Josh65-2201 @yaira2