Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
When you activate a tab to the left of the current tab, the left tab becomes IsCurrentInstance = true before the right tab becomes IsCurrentInstance = false. As a result, there are 2 "current" instances at the same time. This case was mishandled by PageContext. This pr modifies PageContext so that this case is no longer an issue.
The consequence was that when switching tabs to the left, the actions no longer used the correct IShellPage and therefore everything was wrong.
I also removed the reaction to changing ActivePane, as it always involves changing ActivePaneOrColumn. This avoids triggering the change event twice.
Closes File action are disabled for first tab when multiple tabs are open #11701
Validation
How did you test these changes?