Skip to content

Fixed: Selection isn't cleared when switching between panes #11745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2023
Merged

Fixed: Selection isn't cleared when switching between panes #11745

merged 1 commit into from
Mar 16, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Selection isn't cleared when switching between panes #6002

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you implement any design changes to an existing feature?
    • Was this change approved?

yaira2
yaira2 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit a93e956 into files-community:main Mar 16, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 16, 2023
hishitetsu added a commit to hishitetsu/Files that referenced this pull request Mar 18, 2023
@hishitetsu @ferrariofilippo
@yaira2 @cinqmilleans
Resolve path (#17)
981da95 
* Fixed: Selection isn't cleared when switching between panes (files-community#11745)

* New Crowdin updates (files-community#11747)

* Feature: Improved commands for Pin/Unpin (files-community#11729)

* Feature: RichCommands Cut/Copy (files-community#11752)

* Fix PageContext (files-community#11751)

* Feature: Auto update feature of FilesLauncher (files-community#11750)

* Fix: Fixed issue with resolving paths containing dots

---------

Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
Co-authored-by: cinqmilleans <46631671+cinqmilleans@users.noreply.github.com>
Co-authored-by: Filippo Ferrario <f.filippo49@gmail.com>
@ferrariofilippo ferrariofilippo deleted the Clear_Selection_On_Pane_Swap branch March 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Selection isn't cleared when switching between panes
2 participants
@ferrariofilippo @yaira2