-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix: Catch COMException when creating submenus to avoid errors #11363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure if this will completely solve the problem, but there is always a possibility that COMException may occur due to a problem on the DLL side, so I think it is better to merge this code. |
This is a lot better! Should the error notification be removed for these as well? |
I think so because users cannot do anything if they are notified of an error, and it is difficult to fix as a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm still getting a few com exceptions but it's a lot better than before. |
Perhaps we need to review all the places where COMException can occur. |
We can place breakpoints but the errors don't always occur so it's hard to find them all. |
@hishitetsu what do you think about |
Is there any possibility that |
I think so, worst case the user can open the menu again. |
Certainly. I'll work on it. |
Resolved / Related Issues
Items resolved / related issues by this PR.
Details
Here is another possible solution. This way, if "Cast to Device" is not a problem, it can be displayed in the menu.
I can't reproduce the error, so I would like someone to check if applying this PR will stop the error from occurring.
Validation
How did you test these changes?