Skip to content

Fix: Cancel tag edit when pressing esc & Tags duplicate names #11297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 14, 2023
Merged

Fix: Cancel tag edit when pressing esc & Tags duplicate names #11297

merged 4 commits into from
Feb 14, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Feb 14, 2023 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Notes

  • I also removed lines @ 77 and @ 85 which were not really needed

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2 yaira2 changed the title Fixed: Do not close settings esc Fixed: Do not close settings when canceling tag edit Feb 14, 2023
yaira2
yaira2 reviewed Feb 14, 2023
View reviewed changes
yaira2
yaira2 reviewed Feb 14, 2023
View reviewed changes
@yaira2 yaira2 changed the title Fixed: Do not close settings when canceling tag edit Fixed: Cancel tag edit when pressing esc Feb 14, 2023
@ferrariofilippo
Copy link
Contributor Author

@yaira2 can I push here also a fix to #11291 or should I open a different PR (is just two lines)

@yaira2
Copy link
Member

yaira2 commented Feb 14, 2023

@yaira2 can I push here also a fix to #11291 or should I open a different PR (is just two lines)

Might as well combine it 👍

yaira2
yaira2 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferrariofilippo ferrariofilippo changed the title Fixed: Cancel tag edit when pressing esc Fixed: Cancel tag edit when pressing esc & Tags duplicate names Feb 14, 2023
@yaira2 yaira2 merged commit 0699410 into files-community:main Feb 14, 2023
@yaira2 yaira2 changed the title Fixed: Cancel tag edit when pressing esc & Tags duplicate names Fix: Cancel tag edit when pressing esc & Tags duplicate names Feb 14, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 14, 2023
@ferrariofilippo ferrariofilippo deleted the Do_Not_Close_Settings_Esc branch February 14, 2023 18:47
@ferrariofilippo ferrariofilippo mentioned this pull request Feb 14, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Tags can have similar names Bug: Esc cancels Tag edition rather than closing the Settings
2 participants
@ferrariofilippo @yaira2