Codebase: Make private service fields readonly #11011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecksmosis
changed the title
There was a problem hiding this comment.
I think that private non-static fields should be prefixed by '_'. See 2. Naming notation for variables of code style guidelines
QuaintMako
previously approved these changes
Jan 20, 2023
This I am not sure. This notation has not been enfored for a while on the project (at least for the few months I have been active here). If we decide to enforce it, it will ask for a real effort to refactor the whole project in this direction. A decision should be taken regarding this in a proper discussion. |
|
Can you resolve the merge conflicts? |
|
Done |
yaira2
added
ready to merge
ferrariofilippo
suggested changes
Feb 2, 2023
src/Files.App/Filesystem/FilesystemOperations/ShellFilesystemOperations.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/ShellFilesystemOperations.cs
Outdated
Show resolved
Hide resolved
yaira2
added
needs - code review
and removed
ready to merge
|
That should be everything (according to the quick Visual Studio search I did) |
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
private T Service { get; } = Ioc.Default.GetRequiredService<T>()byreadonlyfield #11008 (if Code Quality: Made private UserSettingsService property into a readonly field #11009 is merged, as this doesn't modify UserSettingsService)Validation
How did you test these changes?