Code Quality: Made private UserSettingsService property into a readonly field #11009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
There was a problem hiding this comment.
Overall, LGTM. I think you should remove braces of single-line ifs
Edit. I think that private non-static fields should be prefixed by '_'. See 2. Naming notation for variables of code style guidelines
From what I see, this rule is not enforced anymore, most of the code base doesn't use it. If we are to do it, that's gonna be a huge cost. |
|
@QuaintMako Can you fix the compilation error? |
|
Line 135 of FoldersViewModel.cs |
yaira2
changed the title
QuaintMako
dismissed stale reviews from ferrariofilippo and hecksmosis
via
a791d3f
hecksmosis
approved these changes
Jan 30, 2023
|
@QuaintMako can you resolve the merge conflicts? |
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
private T Service { get; } = Ioc.Default.GetRequiredService<T>()byreadonlyfield #11008What has been done
private IUserSettingsService UserSettingsService { get; } = Ioc.Default.GetRequiredService<IUserSettingsService>();byprivate readonly IUserSettingsService userSettingsService = Ioc.Default.GetRequiredService<IUserSettingsService>();ifValidation
How did you test these changes?